buddypress-group-email-subscription icon indicating copy to clipboard operation
buddypress-group-email-subscription copied to clipboard

Published 20 hours ago • verified publisher icon boonebgorges

Added function to remove topics from digest when trashed

Open hoegrammer opened this issue 4 years ago • 2 comments

See https://wordpress.org/support/topic/deleted-posts-are-included-in-digests

hoegrammer avatar May 10 '20 16:05 hoegrammer

As I mentioned in the forums, trashing a forum post should, in theory, remove the corresponding activity item.

But bbPress 2.6 broke this functionality if the “Allow topic and reply revision logging” option is disabled under “Settings > Forums” in the admin dashboard.

See https://github.com/bbpress/bbPress/blob/8a1729aa3c9d77609c8a5b2d191894fa93a09d93/src/includes/extend/buddypress/activity.php#L644 and the subsequent reply_delete() call later down the method.

So this PR shouldn't be needed.

The temporary solution for bbPress 2.6 is to re-enable revisions or to patch the lines to remove the revision checks. Related: https://bbpress.trac.wordpress.org/ticket/3328.

r-a-y avatar May 19 '20 21:05 r-a-y

tested on a fresh install and yes you are right, this PR is not needed, sorry to waste your time!

hoegrammer avatar Jun 09 '20 14:06 hoegrammer