StackDeobfuscator icon indicating copy to clipboard operation
StackDeobfuscator copied to clipboard

Add support for Quilt Loader

Open stantios opened this issue 2 years ago • 6 comments

Is your feature request related to a problem? Please describe.

I would like if Quilt Mappings was available as an option to choose from as I don't think everyone wants to use yarn on a quilt user environment, even though it doesn't matter what mappings you use from a user point of view since they'll still get help no matter matter what mappings they use.

Describe the solution you'd like

A configuration option to choose Quilt Mappings, maybe the option could be called 'quilt-mappings'.

Describe alternatives you've considered

None

Additional info

I've also thought of if there is a way for the mod to detect what loader the user is using and automatically download the one related to the loader like yarn for Fabric and quilt-mappings for Quilt and so on.

stantios avatar Mar 23 '23 19:03 stantios

Quilt mappings are somwhat different to fabric, as they use hased mojang mappings as intermediary mappings. I don't know if yarn mappings are even possible on quilt loader and quilt mappings on fabric loader.

booky10 avatar Mar 23 '23 19:03 booky10

Yeah, that's why I suggested the feature of detecting the loader and then downloading the mappings appropriate for the loader that the user uses.

stantios avatar Mar 23 '23 19:03 stantios

The log filters which are used don't work when using quilt. I don't really know why, but the LogUtils#getLogger() method (which is used everywhere in vanilla) doesn't call log filters. Manually calling the method behind it works as intended. https://github.com/QuiltMC/quilt-loader/issues/229 seems to be this exact issue, just with some other mod.

Quilt support will have to wait until that issue is resolved, but I will look into integrating quilt mappings anyway.

booky10 avatar Mar 23 '23 21:03 booky10

Quilt mappings were very easy to integrate (181974a8ebda29846858a828309bf9598dc4af36), they provide intermediary (fabric) -> quilt mappings on their maven.

The incompatibility with quilt still exists, so this issue can remain open.

Edit: Quilt mapping support is now released as v1.2.1 on modrinth + curseforge.

booky10 avatar Mar 23 '23 21:03 booky10

but the LogUtils#getLogger() method (which is used everywhere in vanilla) doesn't call log filters. Manually calling the method behind it works as intended.

well why dont you manuly call the method behind it

Cuteistfox avatar Jan 19 '24 18:01 Cuteistfox

also remove the quilt mappings part of the issue name as it is already implemnted

Cuteistfox avatar Jan 19 '24 18:01 Cuteistfox