bookwyrm icon indicating copy to clipboard operation
bookwyrm copied to clipboard

Summary of the year is showing all the time after being dismissed

Open oculos opened this issue 1 year ago • 3 comments

Describe the bug A clear and concise description of what the bug is.

I am running 0.7.1.

After I dismiss the alert for my 2023 summary, when I log in again it shows.

oculos avatar Jan 05 '24 09:01 oculos

I believe this preference is stored in your browsers local storage, is it possible that your browser is clearing site data when you close it?

mouse-reeve avatar Jan 05 '24 16:01 mouse-reeve

I believe this preference is stored in your browsers local storage, is it possible that your browser is clearing site data when you close it?

That might explain it. I am not sure how it works, but when I open a private window and log in there to bookwyrm, it shows it again.

oculos avatar Jan 05 '24 17:01 oculos

That is consistent with how local storage works -- private browsing uses a different session that doesn't contain your local storage. This isn't really a bug; it sounds like the site is working as expected, but it is totally janky for people like you who are clearing local storage much more frequently than most users. In theory, we could switch to using a database flag for this, but that is a lot more complicated than using local storage, and since this doesn't effect very many people and only for a month out of the year, I'm inclined towards leaving it as is.

mouse-reeve avatar Jan 07 '24 16:01 mouse-reeve