bookwyrm
bookwyrm copied to clipboard
'Unshelving' a book is not working correctly
Describe the bug A book (currently shelved) that is unshelved through the search interface leads to a "Not Found" error.
To Reproduce Steps to reproduce the behavior:
- Search for the (already shelved) book through the search bar.
- Click on the book you have shelved.
- From the left-hand side dropdown menu, choose the option "Remove from xxx" where xxx can be the shelf "To Read", "Read", etc.
- "Not Found" error appears and the book isn't unshelved.
Expected behavior A book currently shelved, and its subsequent unshelving, should remove the book from the shelf it was previously on.
Screenshots
Instance bookwyrm.social
Additional context Add any other context about the problem here.
Desktop (please complete the following information): - OS: ArchLinux - Browser: Mozilla Firefox - Version: 102.0
I think this will be solved by #2195
Hello @mouse-reeve.
I’m trying to add this book again to my “To Read” Shelf and hit the same error.
I think this will be solved by #2195
I'm still experiencing this bug on 2c5811fb6fe70ae7f5de28c0741138c688377aa4
Steps to reproduce:
- Navigate to /book/30369/s/anxious-people
- Attempt to remove from "To Read" list
Result:
- Redirects me to /unshelve/ and displays "Not Found" message
- The book is also not removed from the "To Read" list
Logs:
bookwyrm-web-1 | Not Found: /unshelve/ bookwyrm-nginx-1 | [ip address] - - [19/Dec/2022:08:38:57 +0000] "POST /unshelve/ HTTP/1.1" 404 14431 "/book/30369/s/anxious-people"
I've checked the database, and the book has been removed from bookwyrm_shelfbook
(there is no row where book_id=30369) , but the frontend still appears to think it's in the "To Read" shelf (see screenshot below):
EDIT: after I restarted the server the frontend no longer thinks the book is in the "To Read" shelf
I've noticed that the frontend still shows these books on their old shelve (happens as well when moving a book to a different shelve). I believe there are probably two bugs, one with the Not Found page and the other has to do with the redis panel caching not being busted after changing the shelve of a book.