bookwyrm
bookwyrm copied to clipboard
[WIP] User reading statistics
This PR is the first shot on #963.
I created a new view for user statistics to show reading behaviour over time.
Since I want to keep PRs small, the usability of this one is relatively small. Nevertheless it helps me getting familiar with the codebase.
@Ryuno-Ki let me know when this is in a testable state and I'll build locally to help review 💜
@Ryuno-Ki let me know when this is in a testable state and I'll build locally to help review purple_heart
As mentioned in #963 I plan to write several smaller PRs until the feature is complete. If this poses a problem, I'm happy to switch the target branch.
@mouse-reeve told me, they also prefers many smaller PRs over fewer larger ones.
This PR is already „working” insofar as there is a new tab on a user profile page that can be navigated to (but the content there has not much value right now).
Edit: correct pronoun
@Ryuno-Ki @mouse-reeve uses they/them pronouns.
@tversteeg Thanks for pointing out! I couldn't tell from Mastodon profile or GitHub (using mobile). However, the desktop view shows it. I've updated my comment above and will keep it in mind going forward.
I'm excited about this start! I'm happy with the code here.
Since I generally merge main
into production
to deploy code, I'd like to get to a minimum prod-ready state in this PR before merging. If you'd prefer to keep PRs smaller than that, you could open additional PRs that merge into this one.
If you'd prefer to keep PRs smaller than that, you could open additional PRs that merge into this one.
I'm willing to go this route and will edit the title to demark it as WIP.
you could open additional PRs that merge into this one.
Hm, I think, I need to do so against my fork? => https://github.com/Ryuno-Ki/bookwyrm/pull/1
I merged main
into this branch since I wasn't able to pick it up for two months.
I think that's right. There should be an option when you create the PR to set the branch your new work is compared against. And absolutely no worries about timing, life happens!
No update. Currently struggling with reserving time for coding. I haven't forgotten about this, but it can take some weeks to make progress.
I already see the first merge conflicts crawling up :crying_cat_face:
That should handle the merge conflicts 😄
I became a freelancer in January this year. I believe I will be able to make some time to move forward here soon.