Books don't appear on shelf when adding dates using "+ Add read dates" interface

[pelagikat]

When viewing a book's page and adding reading dates using the + Add read dates button in the centre of the page, the book is not then added to my shelf. I have to use the dropdown on the left of the page under the book's cover image for the book to appear on my shelf.

To Reproduce Steps to reproduce the behavior:

1. Search for a book not on your shelf already
2. Click on '+ Add read dates' in the centre of the page
3. Enter the dates
4. Click "Create"
5. The book has your reading dates listed but if you check your shelves, it has not been added

Expected behavior I would have expected the book to appear on my shelf (sorted by "Read" or "Currently Reading" depending on the dates entered, but that's a second layer of behaviour. The book doesn't appear at all currently).

Screenshots Book added with dates:

My shelves without that book:

Instance bookwyrm.social

Additional context I am a new user so I don't know if this is how things are intended to work. I have discussed this with another experienced user and they suggested that this sounds like a bug.

---

Desktop (please complete the following information): - OS: Debian Bullseye 11.1 - Browser: Chrome - Version 96.0.4664.110

[mouse-reeve]

Thank you for filing this! This is the behavior as designed, but I can see why it's not producing the results you would very reasonably expect. I think the fix here would be is to update that view (https://github.com/bookwyrm-social/bookwyrm/blob/main/bookwyrm/views/reading.py#L155) to shelve the book if it isn't currently on a shelf. That way, if you're currently reading a book, and you add past read dates, the book won't be moved to "finished reading"

Another possibility would be to have a checkbox in that form to add the book to the expected shelf, which would give the user more control, but might be a little confusing.

[hughrun]

@mouse-reeve this also confused me when I was a new user, though when @pelagikat asked me about it I couldn't remember whether it had always worked that way. It's particularly confusing for new users, who are likely to be adding a bunch of books they've recently read as their first action.

So something like this?

1. if book is already on a shelf, don't add it to any other shelves (or only if it's on a default i.e. reading shelf)?
2. if there is a finished reading date, add to Read shelf
3. if there is a start reading date but no finished reading date, add to Reading shelf