BetterTeams icon indicating copy to clipboard operation
BetterTeams copied to clipboard

[BUG] com.booksaw.betterTeams.events.ChestManagement.onHopper() takes too much resources

Open JericNisperos opened this issue 7 months ago • 4 comments

What is the bug?

It seems that even if we disabled the claim chest, Hopper is still being checked which causes the server to lag extensively.

Expected Behaviour

If claim-chests are disabled, it should also disable this process.

How to Reproduce

The plugin was installed and immediately disabled the claiming of chests by setting the permission: betterteams.admin.chest.disable to true. Also disabled the permissions: betterteams.admin.chest.claim and betterteams.chest.claim to false.

Error message

It's not considered as an error but rather a process from the server.

BetterTeams (v4.9.4) Server thread17.40% com.booksaw.betterTeams.events.ChestManagement.onHopper()17.38% com.booksaw.betterTeams.Team.getClaimingTeam()16.58% com.booksaw.betterTeams.team.TeamManager.getClaimingTeam()16.58% org.bukkit.block.DoubleChest.getLeftSide()12.41% org.bukkit.craftbukkit.inventory.CraftInventory.getHolder()12.41% net.minecraft.world.level.block.entity.BlockEntity.getOwner()12.41% net.minecraft.world.level.block.entity.BlockEntity.getOwner()12.41% org.bukkit.craftbukkit.block.CraftBlock.getState()12.41% org.bukkit.craftbukkit.block.CraftBlockStates.getBlockState()12.41% org.bukkit.craftbukkit.block.CraftBlockStates.getBlockState()12.40% org.bukkit.craftbukkit.block.CraftBlockStates$BlockEntityStateFactory.createBlockState()12.40% org.bukkit.craftbukkit.block.CraftBlockStates$BlockEntityStateFactory.createBlockState()12.40% org.bukkit.craftbukkit.block.CraftBlockStates$BlockEntityStateFactory.createBlockState()12.40% org.bukkit.craftbukkit.block.CraftBlockStates$$Lambda.0x00007f619d62dbd0.apply()12.40% org.bukkit.craftbukkit.block.CraftChest.()12.40% org.bukkit.craftbukkit.block.CraftLootable.()12.40% org.bukkit.craftbukkit.block.CraftContainer.()12.40% org.bukkit.craftbukkit.block.CraftBlockEntityState.()12.40% org.bukkit.craftbukkit.block.CraftBlockEntityState.createSnapshot()12.40% net.minecraft.world.level.block.entity.BlockEntity.loadStatic()10.60% image

Output of /teama version

image

Additional Information

This was posted from Discord but Booksaw requested to create this bug report: https://discord.com/channels/295271438112522241/1265291473788866676

Thank you, Booksaw!

JericNisperos avatar Jul 25 '24 14:07 JericNisperos