shipper icon indicating copy to clipboard operation
shipper copied to clipboard

Published 20 hours ago • verified publisher icon bookingcom

Restclient metrics based on GVR always report "Unknown"

Open juliogreff opened this issue 5 years ago • 1 comments

Presumably after the client-go upgrade, our shipper_rest_client_latency_seconds metrics started always reporting gvr="Unknown". We suspect that extractGVR (here) is getting paths in a different way now.

juliogreff avatar Aug 14 '19 08:08 juliogreff

As far as I can tell, this seems to be a regression in client-go. The url object that RESTLatencyMetric.Observe receives always points to https://$host/{prefix}. It's possible that this got introduced in https://github.com/kubernetes/client-go/commit/13b096589c6307cb2634a1d6048eebd96bfd497d

I'll investigate this further and open a PR upstream if needed.

juliogreff avatar Aug 22 '19 13:08 juliogreff