carbonapi icon indicating copy to clipboard operation
carbonapi copied to clipboard
verified publisher icon bookingcom

Consider to merge seriesByTag and aliasByTags to our repo

Open azhiltsov opened this issue 7 years ago • 5 comments

https://github.com/go-graphite/carbonapi/pull/384

azhiltsov avatar Jan 29 '19 12:01 azhiltsov

You might also want to grab those changes alongside the original PR: https://github.com/go-graphite/carbonapi/commit/5f4972d48a31e392e8bad89dcdb496f472c4b379 https://github.com/go-graphite/carbonapi/commit/2406fe74ab136c58fe6ddd34f08787693a25bf6a

Civil avatar Feb 03 '19 17:02 Civil

@Civil Thanks. We will consider this. @gksinghjsr, could you have a look, please?

grzkv avatar Feb 04 '19 08:02 grzkv

https://github.com/go-graphite/carbonapi/commit/5f4972d48a31e392e8bad89dcdb496f472c4b379 is not mergeable. We have refactored these parts of the code. The other one may make sense to merge.

grzkv avatar Feb 04 '19 09:02 grzkv

To clarify, our general strategy is to only consider merging changes in the /expr folder.

grzkv avatar Feb 04 '19 09:02 grzkv

My point was that after the PR was accepted, I've done some changes to it, which you may or may-not want to port. Completely up to you to decide which parts and how.

Civil avatar Feb 04 '19 09:02 Civil