casual icon indicating copy to clipboard operation
casual copied to clipboard

Zip is not a function when using a local

Open devbyray opened this issue 5 years ago • 2 comments

When I set the local to 'nl_NL' the zip is not a function but a property. I think this should be more consistent.

devbyray avatar Mar 13 '19 09:03 devbyray

I think this was introduced by this commit / Pull Request: https://github.com/boo1ean/casual/pull/26/files

It should be a property for every locale and should not be a function for any locale,

Instead of having zip(digits) it should have zip, zip5, and zip9 as properties rather than functions for a more consistent interface.

josher19 avatar Aug 21 '20 19:08 josher19

Used zip_short and zip_long instead of zip5 and zip9 (which is specific to the USA).

josher19 avatar Aug 21 '20 23:08 josher19