bonsai.css icon indicating copy to clipboard operation
bonsai.css copied to clipboard

Default font-size, weight and line-height as CSS variables

Open yvesh opened this issue 2 years ago • 1 comments

Hey @ciar4n,

i feel the basic font-size, line-height and weight in _body.css should be CSS variables too. Would fit into the general scheme and makes overriding them easier, especially because other elements with rem are related to it.

  font-size: 15px;
  line-height: 1.6;
  font-weight: 400;

to

  font-size: var(--text-size, 15px);
  line-height: var(--text-line-height, 1.6);
  font-weight: var(--text-weight, 400);

You used --text as prefix for the other font related settings, so I used it in this example too.

What do you think?

yvesh avatar Aug 31 '21 19:08 yvesh

Hey @yvesh

Yes that makes sense. We have a variable for the base color so stand to reason to also include them for size, weight and line-height. 👍

ciar4n avatar Sep 07 '21 21:09 ciar4n