rust-zookeeper icon indicating copy to clipboard operation
rust-zookeeper copied to clipboard

Published 20 hours ago • verified publisher icon bonifaido

Upgrade to 2018 Edition

Open joshleeb opened this issue 4 years ago • 3 comments

With the 2021 edition "coming soon", @bonifaido WDYT of upgrading to the 2018 edition to ease the future switch to the 2021 edition when released?

joshleeb avatar Sep 23 '20 10:09 joshleeb

Sorry, I don't really get 🙂

bonifaido avatar Sep 23 '20 11:09 bonifaido

My apologies! And forgive me if you're already across this.

This is the Rust edition guide which, TL;DR, talks about how outside of the 6 week release cycle, "editions" are also release every 2 to 3 years.

By default, I believe (based on the guide but could be wrong and in which case will close this issue) that the default edition (if not specified in Cargo.toml) is 2015. Currently the latest is 2018, and in 2021 the plan is to release a new edition.

The edition guide goes into details of what is new/different between the 2015 and 2018 editions. Without going into specific features the areas I'm thinking it will be beneficial to upgrade are

  • With a transition to async (#5, #35)
  • Encouraging others to contribute as the latest standards/idioms will be used
    • Along with smaller upgrades like replacing try!(<expr>) with <expr>?
  • Making it easier to upgrade to the 2021 edition in the future

joshleeb avatar Sep 23 '20 11:09 joshleeb

Sorry @bonifaido just bumping the above :point_up: :slightly_smiling_face:

Happy to put up a few PRs to get this going but wanting to see if you have any thoughts/preferences before jumping in.

joshleeb avatar Oct 10 '20 02:10 joshleeb