Bongjun Jang comments

Results 16 comments of


                                            Bongjun Jang

FSharp.Data.Json serializes some floats as ints

## `Float` is a fallback of `Number` https://github.com/fsprojects/FSharp.Data/blob/bbe54edc63a2d1ca3616f3b847ee34c0a88f91f2/src/FSharp.Data.Json.Core/JsonValue.fs#L34-L46 Please read the comment above. FSharp.Data parses a number into a decimal value first, but if it fails, it parses the number...

Csv schema column names with parenthesis don't work

Can you elaborate with an example.

[RFC] module state for PyModule or builtin module

Related CPython implementations: https://github.com/python/cpython/blob/32f0c8271706550096c454eb512450b85fbfc320/Include/internal/pycore_moduleobject.h#L11-L29 https://github.com/python/cpython/blob/5fd8c574e016aec85725ddc5ced8742267b0e1b3/Modules/_sha3/sha3module.c#L42-L57 --- In C, module state are declared at each module as below: ```c typedef struct { PyObject * some_state; } _module_state; ``` And, a pointer...

Can't get the analyzer to work with Ionide

https://github.com/Zaid-Ajaj/Npgsql.FSharp.Analyzer/blob/798ab4fe989690688d61ed1196ca79bb4e1aca37/src/NpgsqlFSharpAnalyzer/SqlAnalyzer.fs#L30-L35 The error message indicates that `ctx.ParseTree` property is not found. Seems like is its the interface of `Context` object has been changed.

[Cranelift] fold `(or ...) + (neg ...)` to `(and ...)`

Seems like `iadd ... (ineg ty y)` -> `isub ... y` wins over this rule.

[Cranelift] fold `(or ...) + (neg ...)` to `(and ...)`

Just realized that this is another version of the simplification of https://github.com/bytecodealliance/wasmtime/pull/10979 In addition, to @cfallin's comment, all my simplification rules are inspired by LLVM InstCombine rules. For example, this...