aes67-linux-daemon icon indicating copy to clipboard operation
aes67-linux-daemon copied to clipboard

SDP specification adherance

Open glance- opened this issue 3 years ago • 1 comments

I played around with https://github.com/AMWA-TV/sdpoker and found that it complains on (at least) two things in the SDP's generated by aes67-linux-daemon:

1: SDP file includes one or more multicast destinations but does not include any a=source-filter lines as per RFC 4570 Section 3.
2: Line 14: An example in the first published version of ST2110 suggested 'traceable' was acceptable without preceeding it with 'IEEE1588-2008'. This is not a permitted form in RFC 7273 and has been corrected later versions of ST2110-10.

Both are quite easy to fix, by including a a=source-filter: incl IN in the SDP with the multicast group and the source IP we're sending from and the other one would just be replacing a=ts-refclk:ptp=traceable with a=ts-refclk:ptp=IEEE1588-2008:traceable

glance- avatar Sep 16 '22 09:09 glance-

Might even be interesting to look at integrating sdpoker in the test suite to validate the sdp's generated.

glance- avatar Sep 16 '22 09:09 glance-

If I add the source filter attribute to the connection I break compatibility with Dante. For example:

a=source-filter: incl IN IP4 239.1.0.1 10.0.0.9

With the above additional line Dante doesn't show up anymore a daemon Source in the Routing dialog.

bondagit avatar Sep 24 '22 19:09 bondagit

I fixed the two compliance issues in branch issue-94 The one related to the source-filter attribute is currently disabled to avoid breaking compatibility with Dante. To enable it just uncomment lines from 623 to 625.

bondagit avatar Sep 29 '22 15:09 bondagit