brackets-compare icon indicating copy to clipboard operation
brackets-compare copied to clipboard

blinding colors, barely legible

Open KolyaKorruptis opened this issue 8 years ago • 7 comments

This should be obvious by looking at your own screenshots for this extension. The first has a black background, the second has a light grey background with light yellow comparison. Switching to comparison view basically makes me go blind for a while. hiss

Could it use the editor's theme?

KolyaKorruptis avatar Jul 27 '16 12:07 KolyaKorruptis

Yes! i'm looking into getting that to work. there's already an issue for that. https://github.com/bomsy/brackets-compare/issues/21 Thanks!

bomsy avatar Jul 27 '16 15:07 bomsy

Cool. Thank you for the work you're putting into this useful extension.

KolyaKorruptis avatar Jul 27 '16 21:07 KolyaKorruptis

I got the text to be darker, i tried doing the BG color but its fetched from a file in different directory. Perhaps you need to add custom CSS that overrules the other one.

PS When i change text using revert chunk, a other app Source Tree doesnt see these changes? thats weird. But this is different thing than this post

schroef avatar Jan 15 '17 21:01 schroef

I think i got something working here, ive adjusted it to my main theme, Dark Material Theme 2.

I just need to get the text in the chunk better visible screen shot 2017-01-15 at 6 44 29 pm

schroef avatar Jan 15 '17 22:01 schroef

@schroef how did you fix it?

smartsystemdesign avatar Apr 25 '18 21:04 smartsystemdesign

@smartsystemdesign, i used the dev tools to see what part of brackets CSS was causing the light background. Then i edited that and restarted. The downside is you need to this each time you update.

See the images, you need to edit codemirror-scroll {backgroundcolor: #f8f8f8}

Open the dev tool, see inthe bottom where it probably says "errors" in red. You can see it in the previous image i posted, if you click that the dev tools open, just like in Chrome. Then by highlighting and opening, i found the corresponding css code for the background color screen shot 2018-04-26 at 12 14 08 pm

On OSX its located here, but you can see that when you hover over the style in the dev tool checker. screen shot 2018-04-26 at 12 15 33 pm

schroef avatar Apr 26 '18 16:04 schroef

Thank you! I'll try that.

smartsystemdesign avatar May 02 '18 14:05 smartsystemdesign