brackets-compare icon indicating copy to clipboard operation
brackets-compare copied to clipboard

The comparison function doesn't work

Open zd-project opened this issue 8 years ago • 22 comments

screen shot 2016-05-03 at 2 47 04 pm

There's not any highlights and comments concerning the difference between two HTML files.

Is this some kind of bug or just that I use it the wrong way?

zd-project avatar May 03 '16 06:05 zd-project

There might be some conflicts with another extension. try to disable the others and see.

bomsy avatar May 03 '16 07:05 bomsy

I have the same issue. You click the icon and the new pane appears empty. I have disabled all other extensions and the issue remains.

tallchap67 avatar May 10 '16 15:05 tallchap67

Yes. I have the exact same problem. Too bad. I don't see any other extension that can be used to compare.

davehallowell avatar May 10 '16 16:05 davehallowell

Same issue. Doesn't highlight even with all other extensions disabled.

crezaii avatar May 10 '16 22:05 crezaii

confirming +1

npoku avatar May 10 '16 22:05 npoku

Looking into this. what versions of brackets are you guys using?

bomsy avatar May 11 '16 09:05 bomsy

I'm using the latest version: 1.6.

crezaii avatar May 11 '16 20:05 crezaii

I am using Release 1.6 build 1.6.0-16680.

davehallowell avatar May 13 '16 13:05 davehallowell

same issue on version1.6

xuefengwork avatar May 18 '16 08:05 xuefengwork

Release 1.6 build 1.6.0-16680 (release 3df0ac6fa) Thanks for taking care of this. Let me know if I should provide additional information.

zd-project avatar May 18 '16 12:05 zd-project

Same here, same release as ZDProject. Tried with all other extensions disabled as well, but it won't work.

ngrisouard avatar May 28 '16 00:05 ngrisouard

I had the same issue...nothing changed when I clicked compare. I disable the only other extension I had installed (Extract for Brackets) and now when I click the compare button it opens in a full white screen where I can see a little bit of code but completely unusable.

capture

dterrazas avatar Jun 20 '16 12:06 dterrazas

tl;dr: probably won't fix

I was having the same issue. Clicking the compare button doesn't do anything. Disabled all other extensions, didn't help too.

Here is the error in the javascript console that is logged when I click the Compare button:

/thirdparty/CodeMirror/lib/codemirror.js:187 Uncaught TypeError: Cannot read property 'first' of null
Display @ /thirdparty/CodeMirror/lib/codemirror.js:187
CodeMirror @ /thirdparty/CodeMirror/lib/codemirror.js:74
CodeMirror @ /thirdparty/CodeMirror/lib/codemirror.js:62
CodeMirror.MergeView @ cm_merge.js:471
CodeMirror.MergeView @ cm_merge.js:439
(anonymous function) @ main.js:116
switchCompareMode @ main.js:56
(anonymous function) @ main.js:111
n.event.dispatch @ thirdparty.min.js:20
r.handle @ thirdparty.min.js:20

Using Brackets Release 1.7 build 1.7.0-16898 (release b0a363b71).

When debugging the main.js of this extension (brackets-compare), it seems that mFile and oFile in lines 94-127 are not null, but their _contents property is null.

image

This is because of this code in Brackets:

            // Only cache data for watched files
            if (watched) {
                this._stat = stat;
                this._contents = data;
            }

That means that this extension won't work unless you select the directory where the files are located. Users need to click "Open Folder" in the left pane of Brackets, and select the files to compare from that folder only.

anton-bot avatar Jul 05 '16 03:07 anton-bot

"you select the directory where the files are located. Users need to click "Open Folder" in the left pane of Brackets, and select the files to compare from that folder only."

For further clarification, the does not work on files in subfolders of the selected folder. As @J3QQ4 describes, you must first "Open folder ..." and select the folder that directly has the files to compare.

This makes is good for single files but not for projects. Even with single files, it would be helpful to be able to compare files from different directories. (not being an 'extensions developer', I am not sure how difficult this will be)

bradanlane avatar Jul 12 '16 13:07 bradanlane

hey guys, I've released v 0.2.5. Please update and see if issues are fix.

bomsy avatar Jul 19 '16 22:07 bomsy

latest version is 0.2.6, Should fix all issues.

bomsy avatar Jul 19 '16 23:07 bomsy

Well I'm now on 0.2.7 and it still doesn't work unfortunately.

SkellyCT avatar Jul 23 '16 12:07 SkellyCT

what issue are you getting?

bomsy avatar Jul 23 '16 13:07 bomsy

It simply doesn't do anything. Doesn't compare. I have updated to all the latest versions.
I have two documents open but when I click on the compare icon nothing happens. I used existing long ones and tried new short ones to test. Nothing.

On 23. Juli 2016 at 15:02:19, Hubert Boma Manilla ([email protected](mailto:[email protected])) wrote:

what issue are you getting?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub(https://github.com/bomsy/brackets-compare/issues/25#issuecomment-234717103), or mute the thread(https://github.com/notifications/unsubscribe-auth/ARim1-M5PD4wJYMnNZ4YiWF-22Ly-TtGks5qYhDbgaJpZM4IV9-J).

SkellyCT avatar Jul 24 '16 10:07 SkellyCT

@SkellyCT you should press F12 to see if there are any error in the javascript console.

anton-bot avatar Jul 24 '16 15:07 anton-bot

@SkellyCT Ur probably getting a specific issue. pls could you press F12 as mention by @J3QQ4, and let me know so i can fix it up for you. thanks!!

bomsy avatar Jul 25 '16 13:07 bomsy

Just in case it helps someone else in the future, I had to save the files first before the comparison plugin worked. IE, you can't just copy paste stuff into an unsaved file and click diff icon.

webs05 avatar Aug 01 '18 14:08 webs05