wsl
wsl copied to clipboard
bombsimon
␊ Whitespace Linter - Forces you to use empty lines!
the golangci reference documentation is using the correct key: https://github.com/golangci/golangci-lint/blob/4b218e664c8488364a1ebc001c07949073e2d611/.golangci.reference.yml#L1785 but the wsl documentation is using what I presume to be the old version of the flag: https://github.com/bombsimon/wsl/blob/master/doc/configuration.md#enforce-err-cuddling
This linter has been in a maintenance like mode for a while and never got the fixer implemented. One of the reasons the fixer never got added was that I...
I see this as just fine: ```go // ... } } return ``` ```go // ... if err != nil return nil, err } return // "bad" } ``` >...
The rule for a block should not start with a whitespace should not apply to a multiline function signature. Instead a no cuddle rule should be in place instead. Example...
Is it by design, or in anyway intended that the following cuddled statements inside the anonymous function are *not* hit by `wsl` ? ``` package main import "fmt" func main()...
Hi, I found a part of my code which wsl should have reported linting errors, but hasn't because I found out that the comments are also considered as "block separators"....
In this PR https://github.com/bombsimon/wsl/pull/37/files#diff-676fb336aa3ff093ebaa37c4293f1cd1R417 the issue was addressed just for `Close` method, but in my opinion it applies to **any method** that is used in a similar way. Here is...
There is often a need to add a value to a wait group and then calling a go routine that will mark done on that wait group as soon as...
Just a suggestion, I can also see it as intentional, since it would allow too complicated blocks maybe. I stumble a lot into that in my code, so I have...
My original function: ```go func sortedKeys(m map[string]interface{}) sort.StringSlice { keys := make(sort.StringSlice, len(m)) i := 0 for k := range m { // ranges should only be cuddled with assignments...
