backward-cpp icon indicating copy to clipboard operation
backward-cpp copied to clipboard

UNW_INIT_SIGNAL_FRAME is not a #define anymore

Open tstack opened this issue 4 years ago • 1 comments

It looks like UNW_INIT_SIGNAL_FRAME is now an enum and no longer a #define:

https://git.savannah.nongnu.org/cgit/libunwind.git/tree/include/libunwind-common.h.in#n104

As a result, the following check and usage are not working correctly:

https://github.com/bombela/backward-cpp/blob/77946058afe52a1d43f5b6243384fe45e7c2aa64/BackwardConfig.cmake#L66

https://github.com/bombela/backward-cpp/blob/77946058afe52a1d43f5b6243384fe45e7c2aa64/backward.hpp#L1022

tstack avatar May 25 '21 00:05 tstack

Well, that's unfortunate. I suppose we could use a bit of SFINAE (substitution failure is not an error) magic for the .hpp part. Not fun.

Any ideas?

bombela avatar May 25 '21 02:05 bombela