Xiaofan Hu comments

Results 105 comments of


                                            Xiaofan Hu

fix: controller: ensures workflow reconciling task result properly when failing to received timely updates from api server

> It seems that the problem of output not being displayed cannot be solved That's strange. I don't have this problem on my simulation. Once the controller was able to...

fix: controller: ensures workflow reconciling task result properly when failing to received timely updates from api server

> If the pod has been successfully created, but the taskresult has not been updated by watch, and mark TaskResultStatus is true, will the previously fixed problem（https://github.com/argoproj/argo-workflows/pull/12537 ） occur again?...

fix: controller: ensures workflow reconciling task result properly when failing to received timely updates from api server

> > I think we need a rethink of how we handle taskresults/pod statuses together. > > We (as open source contributors, not assigning any blame to anyone here) keep...

fix: controller: ensures workflow reconciling task result properly when failing to received timely updates from api server

> Would it make sense to remove the tmpl.HasOutputs() check? (I'm new to the codebase, so I’d appreciate any insights on this.) hi @cyyangnb, thanks for the feedback. I was...

fix: controller: ensures workflow reconciling task result properly when failing to received timely updates from api server

Thanks @cyyangnb. I have incorporated your fix in my patch. @tczhao @shuangkun Should we consider merging this? Given the feedbacks, it's a real problem and this fix seems reasonable for...