howdy icon indicating copy to clipboard operation
howdy copied to clipboard

Behavior of config variable ignore_closed_lid is inverted

Open redcubie opened this issue 3 years ago • 2 comments

Current behavior is when ignore_closed_lid is true, the lid state is checked and when it's false, the lid state is ignored. The expected behavior is when an "ignore" variable is true, the thing gets ignored.

FIX: change line 30 of pam.py to if not config.getboolean("core", "ignore_closed_lid"): OR change all occurrences of ignore_closed_lid to sense_closed_lid

redcubie avatar Jul 07 '21 12:07 redcubie

Yeah this was discussed at the time of implementing, and is caused by the prior naming of ignore_ssh. Both of them were named from the perspective of PAM, so whether PAM should ignore (skip) the module if the lid is closed. I agree it's not a very intuitive way to name them, i'm open for suggestions. Personally, i don't think "sense_closed_lid" would be ideal either, as it doesn't just sense the state, it stops execution

boltgolt avatar Jul 07 '21 13:07 boltgolt

Another option would be to rename it to ignore_when_lid_closed or cancel_when_lid_closed

redcubie avatar Jul 07 '21 14:07 redcubie