core icon indicating copy to clipboard operation
core copied to clipboard

Published 20 hours ago • verified publisher icon bolt

Re-enable multiple db table prefixes

Open simongroenewolt opened this issue 3 years ago • 3 comments

Force initialization of ObjectManager for correct spl_object_hash() behavior. Needed to get the correct spl_object_hash in case it is a proxy

Still needed: revert some changes that were done as workaround for the incorrect behavior of spl_object_hash()

simongroenewolt avatar Dec 02 '20 09:12 simongroenewolt

@bobdenotter I just realized that without talking about it this PR will just be forgotten :-)

Are you interested in getting this merged? I've still marked it WIP as the change itself doesn't do anything, it merely makes it possible to revert your old workaround that made it impossible to have multiple table prefixes. I'm a bit wary to include a revert of those changes in this PR, but maybe that would be the correct thing to do?

simongroenewolt avatar Dec 23 '20 19:12 simongroenewolt

Are you interested in getting this merged?

Yes, certainly. What I've done there was undeniably a hack. If we can revert it, I'm all for it. :-)

bobdenotter avatar Jan 10 '21 11:01 bobdenotter

Now this PR actually re-enbles the use of different table prefixes -- I've reverted the workaround. As I didn't have time to actually test it I'll mark the PR 'work in progress' again.

simongroenewolt avatar May 11 '21 18:05 simongroenewolt