core icon indicating copy to clipboard operation
core copied to clipboard

[accesibility] Add accessible names to checkboxes

Open Chi-teck opened this issue 3 years ago • 3 comments

Details

Currently checkbox in admin listings are rendered with empty labels. https://github.com/bolt/core/blob/4.1/assets/js/app/listing/Components/Filter.vue#L8

That leads to bad accessibiltiy.

Question Answer
Relevant Bolt Version 4.1
Install type Composer install
BC Break no
PHP version 7.4
Web server Nginx
For UX/UI issues Google Chrome

Proposed solution

Add accessible names and apply "visually-hidden" class to these labels. Something like this

<label class="visually-hidden">Select all</label>

Chi-teck avatar Nov 26 '20 10:11 Chi-teck

Hi @Chi-teck , nice catch and tracking the source of the issue.

Can I assign this issue to you? :-)

I-Valchev avatar Nov 26 '20 13:11 I-Valchev

@I-Valchev I am not quite familiar with Bolt internals to fix this properly.

Chi-teck avatar Nov 26 '20 13:11 Chi-teck

This is fixed in: https://github.com/bolt/core/pull/2545. Not sure why that doesn't pop up here.

DorienD avatar May 19 '21 12:05 DorienD