Michael Bolin

surface error in `sl pr` if no default branch exists

2

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #263 * #262

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #263 * __->__ #262

I believe that `atom-package-deps` should already be taking care of this. It should have been fixed in v2.1.3 according to its changelog, which admittedly is the version of `atom-package-deps` that...

On Ubuntu and macOS, we use package managers (`apt`, `brew`) to install Sapling, which makes it straightforward to depend on the platform's latest Node.js package so we don't have to...

https://github.com/facebook/sapling/pull/294 added a Troubleshooting section to explain what to do when this happens, but this is only helpful if someone happens to Google it and find the answer. We should...

[BUG] prefer child_process.execFile() to child_process.exec()

2

**Describe the bug** Building up a command string using user-provided arguments and passing it to `child_process.exec()` runs the risk of shell injection. This can be easily avoided by switching from...

[github] update _strip_stack_information() to recognize \r\n

1

[github] update _strip_stack_information() to recognize \r\n By default, Sapling programmatically writes the PR body on GitHub and will continue to overwrite it every time the user runs `sl pr submit`....

[bug] remove decode() because type is str not bytes

3

[bug] remove decode() because type is str not bytes

Document SL_AUTOMATION on the website.

1

`SL_AUTOMATION` is an incredibly useful environment variable, but `rg SL_AUTOMATION website` does not match anything, so it does not appear to be documented in a way that is Google-able/linkable.

Does not follow HTTP 301 redirects

3

I suspect this is because this uses Node's built-in `http` and `https` modules, which do not supports this. Perhaps the simplest thing is to use: https://github.com/follow-redirects/follow-redirects