bmi088-arduino icon indicating copy to clipboard operation
bmi088-arduino copied to clipboard

cannot be used on esp32

Open mikeleib opened this issue 3 years ago • 3 comments

Due to definition of OPEN_DRAIN at https://github.com/espressif/arduino-esp32/blob/master/cores/esp32/esp32-hal-gpio.h#L50, this library cannot be compiled on an esp32.

mikeleib avatar Nov 08 '21 04:11 mikeleib

Can you bug the ESP32 Core Developers to scope this better? Using macros ignores scoping rules of the language and is causing this issue; if they had scoped it as a const or an enum, we wouldn't have a problem since OPEN_DRAIN is defined within the scope of the BMI088 class.

flybrianfly avatar Nov 11 '21 20:11 flybrianfly

What is the fix for this?

svetgeorgiev avatar Jan 23 '23 23:01 svetgeorgiev

Either get the ESP32 devs to not use macros or rename OPEN_DRAIN in this library to something else.

flybrianfly avatar Jan 23 '23 23:01 flybrianfly