Windows Support?

[ramkumarkb]

Hi,

First of all, thank you for this wonderful project.

I was wondering if there are any limitations to support Windows platform for unFTP?

[hannesdejager]

Hi there. Thank you! No reason except human resources :-). We’ve heard it compiles on windows, not sure if it runs. Do you want to try it and give feedback?

[ramkumarkb]

@hannesdejager - Thank you for your reply. I am new to Rust but definitely would like to try and build-test this on Windows.

[hannesdejager]

Would be nice to get some feedback on this. I don’t have a windows machine or vm set up at the moment to test on windows, but would be nice if it works there too

[J-F-Liu]

Build on Windows failed:

error[E0432]: unresolved import `tokio::signal::unix`
  --> src\main.rs:39:13
   |
39 |     signal::unix::{signal, SignalKind},
   |             ^^^^ could not find `unix` in `signal`

error[E0599]: no method named `poll` found for struct `Pin<&mut _>` in the current scope
   --> src\main.rs:422:20
    |
422 |       let sig_name = tokio::select! {
    |  ____________________^
423 | |         Some(_signal) = term_sig.recv() => {
424 | |             "SIG_TERM"
425 | |         },
...   |
428 | |         },
429 | |     };
    | |_____^ method not found in `Pin<&mut _>`
    |
    = note: `fut` is a function, perhaps you wish to call it
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0599]: no method named `poll` found for struct `Pin<_>` in the current scope
   --> src\main.rs:422:20
    |
422 |       let sig_name = tokio::select! {
    |  ____________________^
423 | |         Some(_signal) = term_sig.recv() => {
424 | |             "SIG_TERM"
425 | |         },
...   |
428 | |         },
429 | |     };
    | |_____^ method not found in `Pin<_>`
    |
    = note: `fut` is a function, perhaps you wish to call it
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to 3 previous errors

[hannesdejager]

Hi @ramkumarkb , @J-F-Liu . I've fixed the windows builds and there is a build available here now:

https://github.com/bolcom/unFTP/actions/runs/4246819517

Do you perhaps want to test it out for us and give feedback?

[J-F-Liu]

Did a simple test for download and upload files, works well, thanks.

[hannesdejager]

@J-F-Liu Great thank you for checking

[ramkumarkb]

Hi @ramkumarkb , @J-F-Liu . I've fixed the windows builds and there is a build available here now:

https://github.com/bolcom/unFTP/actions/runs/4246819517

Do you perhaps want to test it out for us and give feedback?

@hannesdejager - Thank you very much for this Windows build. I will test the same in the next couple of days and will report back.

[hannesdejager]

I'm closing this ticket. If new issues are found on windows we can log more specific issues.