bokysan
Include ldap support in docker image
Fixes #204
Includes the postfix-ldap package in both debian and alpine docker images.
Hi, looks OK. Tests are successful.
I would suggest:
- updating documentation
- writing some tests
- moving from DRAFT to FINAL so I can merge.
Cheers, B
Will do, thanks. I've been sidetracked this week with some unrelated database issues that I need to track down. Once I get that figured out (hopefully tonight) I'll finish this up. In addition I want to fully test that ldap is working with only that package being installed before I undraft it. Last I left it, I was getting an error binding, but I'm pretty sure that's just my config.
I should have some time to work on this over the weekend. What kind of tests are you looking for? It should be easy enough to test that when an ldap map is configured it doesn't give the error that ldap isn't supported. Doing anything beyond that would require setting up and configuring an ldap server for the test.
@bokysan I added some integration tests, but I'm not sure that they're actually meaningful. When I run them locally, via integration-tests.sh, they all always seem to pass. Even when I try to break an existing integration test and run it, it still passes. Is there something in particular I need to do to run them locally?
I'd be happy to update documentation if you think there is something meaningful to add, but this is just enabling a standard type of map in postfix. There's no config needed to enable support for them and it would be better if users went to postfix's documentation on how to use ldap maps.
You can semi ignore that previous comment, I rewrote the ldap tests to use postmap instead of trying to send an email and I verified that it actually fails if ldap isn't working. I still always get successes on the other tests, but that's less of a concern to me since I didn't touch their functionality.
Yeah, missed it. There we go.
I'll test it out a bit and make a release this week.