re-bulma icon indicating copy to clipboard operation
re-bulma copied to clipboard

utilize classnames library instead of manually joining classes

Open capaj opened this issue 9 years ago • 4 comments

joining often creates unneeded spaces, which results in something like

class="tabs    is-fullwidth"

This could be much better if re-bulma used classnames. The same bug is #50

capaj avatar Feb 13 '17 07:02 capaj

@capaj thanks. If you want to customize re-bulma, may I invite you to this repogitory as collaborator?

bokuweb avatar Feb 13 '17 07:02 bokuweb

@bokuweb sure. I can't promise I'll have time to fix this soon, but I can at least start on this in a branch.

capaj avatar Feb 13 '17 07:02 capaj

Please keep down the number of dependancies at all costs.

gurre avatar Nov 30 '17 11:11 gurre

@gurre the lib is 50 lines of code and it will probably save around 100 LOC on this project. Well worth it.

capaj avatar Nov 30 '17 19:11 capaj