font-awesome-rails icon indicating copy to clipboard operation
font-awesome-rails copied to clipboard

Published 20 hours ago • verified publisher icon bokmann

Add font-display: block to font face declaration

Open PikachuEXE opened this issue 4 years ago • 2 comments

Lighthouse is warning about it and some browsers would use incorrect behaviour (swap) if auto or nothing provided Issue on FA: https://github.com/FortAwesome/Font-Awesome/issues/16077

Change already scheduled for FA 5.12.2 https://github.com/FortAwesome/Font-Awesome/issues/16077#issuecomment-594581049

PikachuEXE avatar Mar 20 '20 02:03 PikachuEXE

That's interesting. I proposed swap, but yeah, maybe block is better.

firedev avatar Sep 26 '21 18:09 firedev

Hi, I was about to create a new pull request about this subject also. I suggest "font-display: swap", as it is recommended by Google here https://web.dev/font-display/?utm_source=lighthouse&utm_medium=devtools#how-to-avoid-showing-invisible-text Problem with "font-display: block" is that it may delay FCP. What do you think ?

ABrisset avatar Sep 30 '21 05:09 ABrisset