Tokens icon indicating copy to clipboard operation
Tokens copied to clipboard

PrincessLeia ICO - SafeMath

Open 1pocketaces1 opened this issue 6 years ago • 1 comments

Hi, thank you so much for your resources! I had an issue formatting and including SafeMath the way yit was done in this ico contract, and wanted to share the fix in case anyone else ran into it.

The included library for SafeMath has all of the functions as "public," which is the way it should be if it were a separate .sol file. They should be changed to "internal" when included the way they are here! I checked the other files in which SafeMath was included internally, and they all had "internal" the way it should be. So I guess this may have just been lost in the mix as later files use the SafeMath contract instead of library.

1pocketaces1 avatar Mar 12 '18 02:03 1pocketaces1

https://github.com/bokkypoobah/Tokens/issues/1#issue-304219566

Dejzi31 avatar Sep 23 '21 20:09 Dejzi31