Brett Okken

Results 61 comments of Brett Okken

@davecramer and @vlsi, any feedback on this PR? Can we get it merged?

@vlsi, is there anything I can do to help move this along?

I am having a difficult time coming up with a great test. If I parse the same statement repeatedly, only the first time is a hard parse and subsequent calls...

@vlsi, does that provide the info you were looking for? Is there something specific about the style or approach you dislike?

@vlsi, do you have any thoughts or suggestions on this?

My understanding of the timestamp and timestamptz data types is that both are effectively some fractional second offset since epoch, but the difference is that for timestamp epoch is Jan...

@davecramer, the binary parsing[1] of `timestamp` shows how we adjust the offset from epoch from some timezone. Note the comments about dragons. [1] - https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/java/org/postgresql/jdbc/TimestampUtils.java#L1211-L1215

@davecramer, `LocalDateTime` maps really well to the Oracle `DATE` or `TIMESTAMP` data types. Neither of those are natively offset constructs. Rather they have year, month, day, hour, minute, seconds values....

@marschall, are you suggesting to use the `plus`[1] and `until`[2] methods to convert from/to binary representation for `timestamp`? Assuming that actually aligns with how postgresql does the calculations, that would...

Postgresql does not actually store any timezone or offset information as part of timestamptz. It is effectively identical to `Instant`.