Bojan Zivanovic
Bojan Zivanovic
Thanks, I'll review this in ~7 days.
I approve of the general idea. This also allows people to register currencies that have been phased out, and it could also allow overriding info for existing currencies. Let's negotiate...
To be honest, in a decade of writing eCommerce applications, I've never had the use case for a Split method. Would love to hear yours? In general, I'm not against...
I totally get the argument for keeping the remove-x-internal decorator simple, since it currently doesn't care about which level it is operating on. Perhaps it would make sense to add...
This is the decorator that I ended up using: ```js const id = "internal"; const httpVerbs = ['get', 'head', 'post', 'put', 'patch', 'delete', 'options', 'trace']; /** @type {import('@redocly/cli').CustomRulesConfig} */ const...
@dejurin Hi, will you be addressing this PR's feedback in the next 30 days? I'd like to plan the next release.
Replaced by https://github.com/bojanz/currency/commit/25f70613aad50a6454a03537da9dd2177f3757e3.
The trade-off here is memory usage and binary size. The current data that we ship is fairly small, the file is ~40kb, though that doesn't translate to equivalent memory usage...