nx-aws icon indicating copy to clipboard operation
nx-aws copied to clipboard

normalized windows paths in S3 storage

Open ChrisKeck opened this issue 1 year ago • 2 comments

First of all, thank you very much for the plugin.

Problem: Unfortunately, I'm developing on a Windows computer and have a problem where "/" is normalized to "" in this function https://github.com/bojanbass/nx-aws/blob/ddcc209d6a6f7612e0de30485edb865ed8cdbdb0/packages/nx-aws- cache/src/tasks-runner/aws-cache.ts#L247 .

Possible Solution: The easiest way is to insert a replace("\","/") after the "join". This means that Windows can work properly and the files do not end up on the S3 storage from a Windows computer with “xyz\123.tar.gz”.

ChrisKeck avatar Nov 29 '23 09:11 ChrisKeck

@ChrisKeck i just made a pr that fixes this problem, i think https://github.com/bojanbass/nx-aws/pull/501

Banegasn avatar Jan 15 '24 12:01 Banegasn

PR looks good! Please merge it. Thank you!

ChrisKeck avatar Apr 05 '24 21:04 ChrisKeck

Issue persists. Will it be merged?

ardabeyazoglu avatar Aug 08 '24 12:08 ardabeyazoglu

This has been release in https://github.com/bojanbass/nx-aws/releases/tag/v3.2.2. Please check and close the issue if it's working correctly.

bojanbass avatar Aug 10 '24 12:08 bojanbass

It works.

ardabeyazoglu avatar Aug 11 '24 12:08 ardabeyazoglu