Boris Hermans comments

Results 40 comments of


                                            Boris Hermans

PR to add hook on Configuration updateValue

On it for QA by dev!

PR to add hook on Configuration updateValue

Tested and it's works like a charm! ✅

Generate password button for employee in back office does not work

I reproduce also in `8.1.x`, and it looks like that isn't be implemented at all ?! 🤔

fix: set by default enable action if module is disabled instead of configure action

Hello! Thanks for you PR, and yeah I think that could be better to do this fix in 8.1.x branch. Can you change that? :)

Update iframe-modal.ts DOM text reinterpreted as HTML

> Hi @boherm Thanks For Reviewing Is there Anything Else is Required From My Side to get this Merged in Project? > > Regards No, just to wait a second...

Add 2 hooks in getImageLink

Thanks @ludoviccardinale!

If in request body to create produit id_default_category is 0 we have…

Reopen PR to restart CI. (some checks are failling for no real reason 😅)

If in request body to create produit id_default_category is 0 we have…

Just FYI @Mch0, I had rewrite the title of your PR for changelog purpose ;)

If in request body to create produit id_default_category is 0 we have…

Hi @Mch0! After review by the QA team, your PR fix an uncritical bug and so we can't merge your PR in 8.2.x branch anymore. PS 9.0.0 is now out...

Fresh install backend login 500 error: Argument #9 ($precision) must be of type int, string given

Hi @MyersN13, can you check if this PR https://github.com/PrestaShop/PrestaShop/pull/38905 fix this issue? In that case, maybe we can close this issue! 😄