Bogdan Drutu

Results 550 comments of Bogdan Drutu

Does zap provide that configuration, we provide exactly what zap provides.

What do you expect us to do/offer here?

The OC metrics are not at all present anyway when using `telemetry.useOtelForInternalMetrics`, since the bridge which is the most important part is not available.

Just one small clarification: > Currently Collector uses OpenCensus SDK to report its own metrics. Migration to OpenTelemetry metrics SDK started with a feature gate telemetry.useOtelForInternalMetrics. There is a significant...

Closed by #6223 since now all metrics with prometheus otel have also the prefix.

Another option is to ignore the `fmt.Stringer` implementation problem and just use `String`.

Another option is to call `GetString`?

Yes, if we go with `GetX`, we should not panic if not correct type, and return zero initialized value.

@dmitryax thanks for the writeup this helps a lot. My thinking is a bit different about the `Metric`. I think the `data` part in the `Metric` proto is an unfortunate...