Bogdan Drutu

Results 550 comments of Bogdan Drutu

I think this is similar with "abandon" from brave. So the feature that you want is not to turn on sampling, but to turn off sampling. Is that correct?

I think this is related to the discussion about record semantics https://github.com/census-instrumentation/opencensus-specs/pull/159. Also I asked for a flush/shutdown function.

I think this is fixed. Please reopen if work is still left here.

Personally I think we can do a lot of things here: * Disable RunningSpanStore if z-pages are not enable; * Default blocking (allow via a config to disable this); If...

Also I think it will be good to count all these dropped events.

@SergeyKanzhelev for the span.Kind +1. @SergeyKanzhelev catch all exporter can be useful here, but for performance reasons I think we need to only record start/end time just for this. So...

Proposed a more generic solution in https://github.com/census-instrumentation/opencensus-specs/issues/191. This proposal will be just an implementation of the proposed SpanHandler and record_stats bit that will become the TracingLevel.RECORD_LATENCY.

* What is the value of `originator` and `caller`? This only works in systems that have a knowledge of "user" or "service" but does not work in all the systems,...

@g-easy I think we used to have a per-channel argument to disable/enable the filter. Is that still true?

@jkschneider can you take a look at this https://github.com/census-instrumentation/opencensus-specs/pull/51? Also the concept is explained (probably not very well in the following docs): https://godoc.org/go.opencensus.io/stats/view