spoolman2slicer icon indicating copy to clipboard operation
spoolman2slicer copied to clipboard

Create install.sh

Open joseto1298 opened this issue 6 months ago • 1 comments

joseto1298 avatar May 26 '25 18:05 joseto1298

This looks awesome!

I'm away on vacation without a computer right now so I'll review it when I come back home.

Please add spdx copyright tags to the file, like this;

# SPDX-FileCopyrightText: [year] [copyright holder] <[contact address]>

Where FileCopyrightText is the SPDX identifier of the license.

bofh69 avatar May 27 '25 11:05 bofh69

Hi!

Sorry for the very long delay.

I've taken a look at it now. The installation part looks great, but I was confused about the "Create templates" option. It doesn't create the templates, it runs spoolman2slicer and creates the filament configuration files.

I think the "install" option should (if not already existing) create ~/.config/spoolman2slicer/templates-{orcaslicer,superslicer,prusaslicer} and copy the default template files there.

The "Create templates" option should instead be its own script, "run.sh" perhaps? I think it should store the answers somewhere (~/.config/spoolman2slicer/run.config perhaps?) so the defaults the second time is the old answers and the user only has to press return a few times.

I can make these changes after merging if you want.

bofh69 avatar Oct 02 '25 06:10 bofh69

Oh, one more thing. Please change the mode of the script to be runable: chmod 755 install.sh

bofh69 avatar Oct 02 '25 06:10 bofh69

I have made a script modification including and taking into account the comments.

joseto1298 avatar Oct 02 '25 16:10 joseto1298