medieval-mss icon indicating copy to clipboard operation
medieval-mss copied to clipboard

Published 20 hours ago • verified publisher icon bodleian

check behaviour of `<sic>`

Open holfordm opened this issue 7 years ago • 9 comments

Detailed Description

@andrew-morrison previously commented: you might want to look at when sic and choice are used inside a choice. The XSL inserts square brackets for those, and also puts spaces in the wrong places (e.g. https://medieval.bodleian.ox.ac.uk/catalog/manuscript_6230#MS_Holkham_misc_17-item8-item3)

Link to Page

Context

Possible Implementation

holfordm avatar Jan 23 '18 20:01 holfordm

Another question about your use of the sic element: When it is on it's own, as a self-closing tag, what should be displayed? For example:

<note>In the margin, for each, a cross-reference: ‘An other of this page <sic/>’ and ‘An other of this in the later parte.’ </note>

At the moment, nothing is displayed, because the XSL creates an empty span:

<p class="note">In the margin, for each, a cross-reference: ‘An other of this page <span class="sic"></span>’ and ‘An other of this in the later parte.’</p>

I'm removing those, because empty HTML elements confuse web browsers, and are causing problems on the Hebrew and Genziah web sites. I just noticed this while testing the effect on Medieval (no display change) but as this is quite common perhaps it is something that has been overlooked?

andrew-morrison avatar Feb 09 '18 11:02 andrew-morrison

The desired behaviour here is that the empty element should generate the text '[sic]', in the same style as in generated for other sics ([<span class="italic">sic</span>]) I've used the empty element in cases where it wasn't clear exactly what the 'sic' referred to.

From: andrew-morrison [email protected] Sent: 09 February 2018 11:31 To: bodleian/medieval-mss Cc: holfordm; Assign Subject: Re: [bodleian/medieval-mss] check behaviour of <sic> (#117)

Another question about your use of the sic element: When it is on it's own, as a self-closing tag, what should be displayed? For example:

In the margin, for each, a cross-reference: ‘An other of this page ’ and ‘An other of this in the later parte.’

At the moment, nothing is displayedhttps://medieval.bodleian.ox.ac.uk/catalog/manuscript_3933#Christ_Church_MS_150-item8, because the XSL creates an empty span:

In the margin, for each, a cross-reference: ‘An other of this page ’ and ‘An other of this in the later parte.’

I'm removing those, because empty HTML elements confuse web browsers, and are causing problems on the Hebrew and Genziah web sites. I just noticed this while testing the effect on Medieval (no display change) but as this is quite common perhaps it is something that has been overlooked?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/bodleian/medieval-mss/issues/117#issuecomment-364409827, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATThVJweYtrbGDI_eXjcPINwoEkWCLfEks5tTCyWgaJpZM4RqRJp.

holfordm avatar Feb 09 '18 11:02 holfordm

I've implemented that and updated the QA site. Here's the same example now displaying, hopefully correctly.

andrew-morrison avatar Feb 09 '18 12:02 andrew-morrison

I believe this can be closed.

ahankinson avatar Jun 20 '19 10:06 ahankinson

Reopening as the spacing is odd when a correction is involved - unwanted space after '[' no space after 'for'. E.g. https://medieval.bodleian.ox.ac.uk/catalog/manuscript_343, art. 4

Incipit: Litere [ sic forLinee] naturales sunt .iiii.or in planicie omnis chiros

holfordm avatar Jun 21 '19 16:06 holfordm

I believe I have fixed this and re-indexed QA. Here are all records containing <sic>:

http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10111 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10117 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10118 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10134 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10140 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10145 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10182 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_138 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_1499 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_1591 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_343 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_3907 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_3918 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_3919 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_3922 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_3933 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_3940 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_3955 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_4453 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6023 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6230 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6589 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6595 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_7049 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_7894 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_7896 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_8030 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_985

If that looks OK, I can re-index production on Monday.

andrew-morrison avatar Jun 21 '19 17:06 andrew-morrison

Another variant is when <sic> encloses text, without being part of a <choice> element - I don't think this is currently displaying anything?

holfordm avatar Feb 07 '20 12:02 holfordm

What should it display? The text enclosed followed by [sic]?

andrew-morrison avatar Feb 07 '20 15:02 andrew-morrison

I've changed this on QA. These are the affected records:

http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_20 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_61 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_97 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_110 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_1377 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_1450 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_1459 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_1591 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_1852 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_1978 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_1979 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_1987 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_1988 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_1994 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_1996 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_1998 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_2000 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_2001 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_2002 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_2003 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_2004 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_2005 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_2008 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_2015 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_2041 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_2176 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_2218 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_3015 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_3910 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_3915 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_3916 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_3920 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_3926 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_3940 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_4372 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_4415 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_4429 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_4766 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_4834 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_5980 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6023 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6230 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6232 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6294 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6567 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6595 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6661 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6745 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6775 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6778 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6911 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_6953 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_7020 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_7106 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_7231 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_7236 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_7309 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_7368 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_7776 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_7890 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_8030 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_8596 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_8616 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_9501 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10100 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10111 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10112 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10117 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10118 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10119 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10135 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10137 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10142 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10143 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10147 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10165 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10167 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10178 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10183 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10188 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10194 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10210 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10256 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10263 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10269 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10273 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10285 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10302 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10312 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10323 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10324 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10330 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10334 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10335 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10336 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10337 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10340 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10345 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10346 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10347 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10355 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10364 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10373 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10379 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10381 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10383 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10395 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10397 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10398 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10406 http://medieval-qa.bodleian.ox.ac.uk/catalog/manuscript_10420

In some records the fact that these <sic> elements weren't having any visible effect on the web site seems to have led to the cataloguer inserting their own <note>[<hi rend="italic">sic</hi>]</note> into the TEI. Here is an example. Those should probably be searched and replaced before re-indexing the production web site.

andrew-morrison avatar Feb 07 '20 18:02 andrew-morrison