git-flow-completion icon indicating copy to clipboard operation
git-flow-completion copied to clipboard

Not working after upgrading to El Capitan OSX 10.11

Open davidetruffo opened this issue 10 years ago • 34 comments
trafficstars

I just upgraded my OSX and the autocomplete just doesn't work anymore (i hit tab, and i get a list of files in that folder, but not the git-flow commands)

any hint?

davidetruffo avatar Oct 20 '15 12:10 davidetruffo

Not without more info :)

What shell are you using? How did you install git-flow? Do you use an os package manager or shell plugin manager? Does regular git completion work for you? Does any other tab completion (besides files) work?

bobthecow avatar Oct 20 '15 16:10 bobthecow

fair enough :)

i use iTerm + zsh + oh-my, and brew to install most of the packages (used to install both git and git-flow) Regular git completion works, as well as other tab completion (besides files) such as grunt, bower, pip, pyenv, brew, and others.

let me know if you need any further infos

thanks

davidetruffo avatar Oct 20 '15 17:10 davidetruffo

Also doesn't work here.

zsh 5.1.1 (x86_64-apple-darwin15.0.0)

git-flow and zsh installed by homebrew

git and many other tab-completions still work

joshuakarjala avatar Oct 21 '15 05:10 joshuakarjala

@joshuakarjala what version of git are you using.. i have two macbook's both on el capitan.. one works the other doesn't..

Working

  1. zsh 5.0.8
  2. oh-my-zsh - latest from upgrade_oh_my_zsh
  3. git 2.3.8 default installed)

Non Working

  1. zsh 5.0.8
  2. oh-my-zsh - latest from upgrade_oh_my_zsh
  3. git 2.5.3 (installed via homebrew)

mikedevita avatar Oct 23 '15 23:10 mikedevita

  1. zsh 5.1.1
  2. oh-my-zsh - latest from upgrade_oh_my_zsh
  3. git 2..6.2

On Fri, Oct 23, 2015 at 7:21 PM, Mike DeVita [email protected] wrote:

@joshuakarjala https://github.com/joshuakarjala what version of git are you using.. i have two macbook's both on el capitan.. one works the other doesn't.. Working

  1. zsh 5.0.8
  2. oh-my-zsh - latest from upgrade_oh_my_zsh
  3. git 2.3.8

Non Working

  1. zsh 5.0.8
  2. oh-my-zsh - latest from upgrade_oh_my_zsh
  3. git 2.5.3

— Reply to this email directly or view it on GitHub https://github.com/bobthecow/git-flow-completion/issues/43#issuecomment-150714369 .

joshuakarjala avatar Oct 24 '15 11:10 joshuakarjala

I think this has to do with _git completion in /usr/share .. It's not writable on capital because of the system integrity stuff. I could be wrong though. Haven't tested it yet.

Sent from my iPhone

On Oct 24, 2015, at 4:45 AM, Joshua Karjala-Svendsen [email protected] wrote:

  1. zsh 5.1.1
  2. oh-my-zsh - latest from upgrade_oh_my_zsh
  3. git 2..6.2

On Fri, Oct 23, 2015 at 7:21 PM, Mike DeVita [email protected] wrote:

@joshuakarjala https://github.com/joshuakarjala what version of git are you using.. i have two macbook's both on el capitan.. one works the other doesn't.. Working

  1. zsh 5.0.8
  2. oh-my-zsh - latest from upgrade_oh_my_zsh
  3. git 2.3.8

Non Working

  1. zsh 5.0.8
  2. oh-my-zsh - latest from upgrade_oh_my_zsh
  3. git 2.5.3

— Reply to this email directly or view it on GitHub https://github.com/bobthecow/git-flow-completion/issues/43#issuecomment-150714369 .

— Reply to this email directly or view it on GitHub.

mikedevita avatar Oct 24 '15 13:10 mikedevita

same settings as @joshuakarjala here:

  • zsh 5.1.1 (x86_64-apple-darwin15.0.0)
  • oh-my-zsh - latest from upgrade_oh_my_zsh
  • git version 2.6.2
  • iTerm2 Build 2.1.4
  • OS X El Capitan (10.11.1)

davidetruffo avatar Oct 26 '15 10:10 davidetruffo

I got the same error/issue on my fresh install mbp. I have the same environment as @davidetruffo

c0nscience avatar Nov 03 '15 13:11 c0nscience

Same settings as @davidetruffo and I also get the error.

istrasci avatar Nov 04 '15 17:11 istrasci

Hi @bobthecow, any news on this? :)

davidetruffo avatar Nov 17 '15 08:11 davidetruffo

From what I can tell, it should still be working. Looking and git and zsh source, I don't see a reason for it to break. But to be honest, I just don't know. I don't use zsh, so this version of the completion is largely user supported. For fun, can one of you replace your _git completion file with the current HEAD version here:

http://sourceforge.net/p/zsh/code/ci/master/tree/Completion/Unix/Command/_git?format=raw

… and see if that fixes things?

bobthecow avatar Nov 22 '15 17:11 bobthecow

Will try it tomorrow

On 22 Nov 2015, at 18:23, Justin Hileman [email protected] wrote:

From what I can tell, it should still be working. Looking and git and zsh source, I don't see a reason for it to break. But to be honest, I just don't know. I don't use zsh, so this version of the completion is largely user supported. For fun, can one of you replace your _git completion file with the current HEAD version here:

http://sourceforge.net/p/zsh/code/ci/master/tree/Completion/Unix/Command/_git?format=raw

… and see if that fixes things?

— Reply to this email directly or view it on GitHub.

davidetruffo avatar Nov 22 '15 18:11 davidetruffo

@bobthecow no luck.. everything seems to be up to date.. I don't have much knowledge about bash-shell-scripts, but is there any way to make it fail loudly, or to see if the plugin actually loads?

davidetruffo avatar Nov 23 '15 11:11 davidetruffo

I just uninstalled git 2.6.2 and stick with the apple git version and it works all fine

c0nscience avatar Nov 24 '15 13:11 c0nscience

I just tried, and yes, it works properly with the apple version of git (git version 2.4.9 (Apple Git-60))

davidetruffo avatar Nov 25 '15 08:11 davidetruffo

I also confirm it works when downgrading to git version 2.4.9 (Apple Git-60).

istrasci avatar Nov 26 '15 06:11 istrasci

             ###                  User: zx1986
           ####                   Hostname: air
           ###                    Distro: OS X 10.11.1
   #######    #######             Kernel: Darwin
 ######################           Uptime: 2 days
#####################             Shell: /bin/zsh
####################              Terminal: screen iTerm.app
####################              CPU: Intel Core i5-3427U CPU @ 1.80GHz
#####################             Memory: 4 GB
 ######################           Disk: 79%
  ####################            Battery: 100
    ################              IP Address: .......
     ####     #####

zsh 5.1.1 (x86_64-apple-darwin14.5.0) with prezto git version 2.6.3

not working :-(


Maybe because this? https://developer.apple.com/library/mac/documentation/Security/Conceptual/System_Integrity_Protection_Guide/ConfiguringSystemIntegrityProtection/ConfiguringSystemIntegrityProtection.html

zx1986 avatar Nov 29 '15 05:11 zx1986

I have close SIP feature,it also does not work.

EkkoG avatar Dec 25 '15 09:12 EkkoG

Yes,my git installed by Homebrew, when I unlink git,use the system's git,it works.

EkkoG avatar Dec 25 '15 09:12 EkkoG

Any progress on this at all? Still works with git version 2.5.4 (Apple Git-61), but not with the higher-versioned Homebrew ones.

istrasci avatar Mar 07 '16 18:03 istrasci

I faced the same issue. I haven't dug into it too much yet. It's unfortunate as Apple git is very old.

esetnik avatar Mar 10 '16 15:03 esetnik

Hi people!

Just want to highlight that:

  • Mac OS 10.11.3
  • zsh 5.2 (x86_64-apple-darwin15.0.0)
  • git version 2.7.2 (the brewed one)
  • iTerm2 2.9.20160206

~~using git-flow-completion as a plugin~~ it works again

I'm not sure why though :)

davidetruffo avatar Mar 10 '16 15:03 davidetruffo

@davidetruffo can you provide some further configuration to help me get it going? I believe I have the same environment as you. I'm using oh-my-zsh with plugins git-flow-avh and git-flow-completion, but I've tried it with both git-flow and git-flow-avh.

esetnik avatar Mar 10 '16 16:03 esetnik

@esetnik i'll do my best :)

I am using zsh and oh-my-zsh (master branch) (don't know if that makes any difference honestly) I've also realised that i had a git-flow-completion folder in my custom plugins (in .oh-my-zsh/custom/plugins) but it was actually not used (i removed it, and it's still working, maybe it was a legacy from some test i've done)

In my .zshrc file, i have those plugins enabled (i have many others, but those are the ones related to git) git git-flow

In the same file, i also have this line: fpath=(/usr/local/share/zsh-completions $fpath) but then again, i'm not sure if this is related.

Things that i've done recently:

  • update/upgrade brew
  • upgraded to iTerm2 v3 beta (the version number is 2.9.20160206)

Any better? :)

davidetruffo avatar Mar 10 '16 16:03 davidetruffo

@davidetruffo Thanks so much for the detailed analysis. I found two points of discrepancy between my config and yours:

  1. I had git-flow-completion enabled as a plugin. It's actually available in the .oh-my-zsh plugins directory but you may have followed the git-flow-completion instructions at one point which suggests cloning this repo as a custom plugin.
  2. I did not have fpath=(/usr/local/share/zsh-completions $fpath)

I found that a combination of removing the git-flow-completion from the plugins and adding fpath=(/usr/local/share/zsh-completions $fpath) fixed it for me as well!

I'm not sure what that magic line does but it works and it might help @bobthecow get to the bottom of this.

esetnik avatar Mar 11 '16 00:03 esetnik

@esetnik i'm glad i could help a bit :) As far as i know, the magic line should tell zsh where to look for completions patterns. Perhaps zsh made it better and now it works. I'm not sure if this makes sense, so if anyone has some light to shed on this i'd be happy :)

davidetruffo avatar Mar 11 '16 08:03 davidetruffo

@davidetruffo I actually realized that the suggestions you made did not persist to a new shell. I must have had the old Apple git sourced in the old shell. I currently have everything setup the same and can't get git flow completions with the previous solution.

esetnik avatar Mar 13 '16 17:03 esetnik

@esetnik Apologies for the ridiculous late reply! Did you manage to make it work? From my end, i can tell that it works fine now, and i removed the git-flow-completion plugin. Some details:

  • Mac OS 10.11.3
  • zsh 5.2 (x86_64-apple-darwin15.0.0)
  • git version 2.8.2 (the brewed one)
  • iTerm2 Build 2.9.20160426

davidetruffo avatar May 13 '16 11:05 davidetruffo

Unfortunately not. I can only get it working with apple git and not brewed one. On Fri, May 13, 2016 at 7:14 AM Davide Truffo [email protected] wrote:

@esetnik https://github.com/esetnik Apologies for the ridiculous late reply! Did you manage to make it work? From my end, i can tell that it works fine now, and i removed the git-flow-completion plugin. Some details:

  • Mac OS 10.11.3
  • zsh 5.2 (x86_64-apple-darwin15.0.0)
  • git version 2.8.2 (the brewed one)
  • iTerm2 Build 2.9.20160426

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/bobthecow/git-flow-completion/issues/43#issuecomment-219015809

esetnik avatar May 13 '16 12:05 esetnik

out of curiosity, are you using git-flow from brew as well? which version? (i have 0.4.1)

davidetruffo avatar May 13 '16 15:05 davidetruffo