Roberto Esposito
Roberto Esposito
[merge approved]
Hi @surenderk2009, I am very aware of the issue, but as I mention in a a note of the README: > It is worth mentioning that, due to how priority...
Hi, > A cursory look at the code suggests this looks good. Can you please bring the the hyperparmeter struct docstring up to [spec](https://juliaai.github.io/MLJModelInterface.jl/dev/document_strings/)? I've tried to follow the spec,...
> Waiting for: > > * [x] [MLJ model struct must have a default instance ml-unito/PartitionedLS.jl#4](https://github.com/ml-unito/PartitionedLS.jl/issues/4) This has been fixed in commit [6b9a3f7](https://github.com/ml-unito/PartitionedLS.jl/commit/6b9a3f7ceea6a43b057a4f9053b3f0cefd6afaff).
> Thanks @boborbt for that. Would you consider updating the docstring as indicated above? As I mentioned above, I tried my best, but was not able to use the $(MLJModelInterface.doc_header(...))...
I just updated the documentation as suggested (see commit [b1ca7ba9](https://github.com/ml-unito/PartitionedLS.jl/commit/b1ca7ba99cc6aba4c03d58cc737ceab2814d3d67)). By the way, thanks for all the suggestions you gave me. It was worth registering to MLJ just for the...
Any news about this issue? I believe everything needed is in place now.
No problem @ablaom, I just tagged version 1.0.4, registered on Julia general registry and generated a new release on github. The tagged version is [this one](https://github.com/ml-unito/PartitionedLS.jl/commit/ef2496a63cff717dcbea17c51d62b44d77b3cb1e).
Fixed the issue you opened yesterday.