script.xbmc.boblight
script.xbmc.boblight copied to clipboard
bobo1on1
Added option to disable boblight on pause
Mhhh why? IIRC there is already a option which disables it when the screensaver kicks in. While i really appreciate your additions i also have to take care to not overload this addon settings wise.
I've heard the request for the option a lot of times, also from my own family. Apparently some people like it better when the lights dim when you hit pause rather than wait for the screensaver to kick in, so I implemented it to try it out. I have to say: I like it.
It's just one option in the menu and a few lines of code, but I really won't be offended if you decide not to merge this PR :-)
@Memphiz I find this feature very useful since i regular pause video playback and left it paused for a certain amount of time. What then happens is that the leds stay on there last position and that looks kinda weird when you levae it there for, let's say, 10 minutes. When i pause a video the screensaver then never jumps in so like i said it leaves me with some weird color selection shining in my room. I don't think this will overload the addon settings, but that's just my opinion.
@georgehenze I'm not using static so this explains why my leds are off.
@Memphiz that was intentional. If someone wants a static light when they're in the menu I don't see why they'd want to dim the lights when they pause, so the state returns to static. If you've disabled static lights all led's will dim.
Ha - not my day today so i argue back - "if a user wants boblight during a movie i don't see why they'd want to dim the lights when they pause" ;) - but ok ...
I don't get why anyone would want the static light at all, so there you go :-) If you want the behaviour changed, let me know, fine by me. If you do not want to include this PR, fine by me too. It's your addon and your call :-)
Nah i don't care - i will test it and merge then. I have a simple setup. Static lights in the menu - and forced custom category on all content ;)
@Schumi - the screensave not kicking in when paused sounds like a bug. At least at one point it dimmed the screen for me iirc.
Please rebase to master and move the disable_on_pause option to the other disable options (genreal disable and disable on screensaver). And pleas recheck - i bet that disable on screensaver and disable on pause will influence each other ...