hashsplit icon indicating copy to clipboard operation
hashsplit copied to clipboard

WIP: integrate test cases from the hashsplit org test suite.

Open zenhack opened this issue 3 years ago • 1 comments

This patch:

  • Integrates the test cases from the common test suite I started way back when
  • Sets the correct value of G for cp32

It doesn't work, and this should not be merged as-is. But, either we should fix it, or fix the spec, or at least not claim within the README that this is an implementation of what's in the spec.

I suspect the buzhash32 from the library you're using isn't exactly what we specified as cp32. The easiest path may be to just implement it directly.

Note also that the test configs have a maxSize field, which doesn't seem to have an analogue in this library.

zenhack avatar Aug 19 '21 02:08 zenhack

The easiest path may be to just implement it directly.

This now exists at https://github.com/bobg/hashsplit/pull/5 ! I'd be very grateful if you'd take a look. Any chance of getting some test vectors for the cp32 algorithm?

Please note that since you originally wrote this pull request (for which, a very belated thank you), I have dramatically redesigned the API around Go's new iterator feature.

bobg avatar Aug 29 '24 05:08 bobg