boa icon indicating copy to clipboard operation
boa copied to clipboard

extract small_map as separate utility crate

Open countradooku opened this issue 9 months ago • 6 comments

This Pull Request closes #4184 .

It changes the following:

  • extract small_map as separate utility crate

countradooku avatar Mar 22 '25 11:03 countradooku

@jedel1043

countradooku avatar Mar 22 '25 11:03 countradooku

@jedel1043 I think I did something wrong

countradooku avatar Mar 22 '25 17:03 countradooku

@jedel1043 i added docs here

countradooku avatar Mar 23 '25 17:03 countradooku

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.19%. Comparing base (6ddc2b4) to head (5cdb39b). Report is 464 commits behind head on main.

Files with missing lines Patch % Lines
utils/small_btree/src/lib.rs 0.00% 3 Missing :warning:
utils/small_btree/src/entry.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4214      +/-   ##
==========================================
+ Coverage   47.24%   50.19%   +2.95%     
==========================================
  Files         476      499      +23     
  Lines       46892    50165    +3273     
==========================================
+ Hits        22154    25181    +3027     
- Misses      24738    24984     +246     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 23 '25 17:03 codecov[bot]

@Razican i commited your suggestions

countradooku avatar Mar 27 '25 09:03 countradooku

your git history doesn't look right anymore, can you run git rebase -i on it?

oriongonza avatar Mar 27 '25 14:03 oriongonza

Hi @radudiaconu0 :wave:, when you have a moment, could you please implement the suggested changes and rename it to small_btree? That way, we’ll be ready to merge it :smile:

HalidOdat avatar Jun 21 '25 12:06 HalidOdat

Hi @radudiaconu0 :wave:, when you have a moment, could you please implement the suggested changes and rename it to small_btree? That way, we’ll be ready to merge it :smile:

Sure. I was very busy lately with my projects

countradooku avatar Jun 21 '25 13:06 countradooku

@HalidOdat i renamed it. you can merge it

countradooku avatar Jun 30 '25 19:06 countradooku

Rename SmallMap to SmallBTreeMap?

jedel1043 avatar Jun 30 '25 19:06 jedel1043

Rename SmallMap to SmallBTreeMap?

@jedel1043 done

countradooku avatar Jul 04 '25 10:07 countradooku

Very nice! Everything looks correct, this just needs some conflict resolutions and we can merge

jedel1043 avatar Jul 04 '25 14:07 jedel1043