boa icon indicating copy to clipboard operation
boa copied to clipboard

Adding TryFromJs implementations for tuples

Open hansl opened this issue 1 year ago • 3 comments

This make it easier to get the first N values from an array when de-serializing.

hansl avatar May 09 '24 18:05 hansl

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50.78%. Comparing base (6ddc2b4) to head (9008f22). Report is 179 commits behind head on main.

Files Patch % Lines
...engine/src/value/conversions/try_from_js/tuples.rs 50.00% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3843      +/-   ##
==========================================
+ Coverage   47.24%   50.78%   +3.53%     
==========================================
  Files         476      470       -6     
  Lines       46892    45347    -1545     
==========================================
+ Hits        22154    23028     +874     
+ Misses      24738    22319    -2419     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 18:05 codecov[bot]

No idea why the Windows action is failing.

hansl avatar May 09 '24 20:05 hansl

If you rebase the CI should be fixed :smile: There was an issue that was fixed with #3845.

nekevss avatar May 11 '24 18:05 nekevss