boa icon indicating copy to clipboard operation
boa copied to clipboard

Add `JsNativeObject` wrapper

Open johnyob opened this issue 2 years ago • 4 comments

This PR adds a JsNativeObject wrapper around JsObject with the invariant that the underlying object data is a native object of some type T.

johnyob avatar Nov 24 '23 11:11 johnyob

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (07e2356) 44.59% compared to head (5e459a5) 44.55%. Report is 50 commits behind head on main.

Files Patch % Lines
boa_engine/src/object/builtins/jsnative_object.rs 0.00% 40 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3479      +/-   ##
==========================================
- Coverage   44.59%   44.55%   -0.04%     
==========================================
  Files         487      488       +1     
  Lines       50601    50641      +40     
==========================================
  Hits        22563    22563              
- Misses      28038    28078      +40     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 24 '23 11:11 codecov[bot]

Are doc tests not covered by codecov?

johnyob avatar Nov 24 '23 21:11 johnyob

Are doc tests not covered by codecov?

Nope, and I'm not sure if tarpaulin supports testing docs.

jedel1043 avatar Nov 24 '23 21:11 jedel1043

@jedel1043, @raskad and @HalidOdat will try to review this.

jedel1043 avatar Nov 29 '23 19:11 jedel1043