boa icon indicating copy to clipboard operation
boa copied to clipboard

Split `Node` into `Expression`, `Statement` and `Declaration`

Open HalidOdat opened this issue 3 years ago • 5 comments

Currently Node is both a expression, statement and declaration. It would be better if Node was split into how the spec describes it Expression, Statement and also Declaration. Why do we want this? Right now we don't differentiate between statements (like if, while, etc) and expressions (like 2 + 2), while we could make it work like this, it makes somethings awkward like if (cond) {}, cond should only an expression, and when we parse it we check for this, but some checks can be elided if we leverage the type system, making illegal state unrepresentable.

We want to match to what astexplorer outputs.

HalidOdat avatar Jun 29 '21 16:06 HalidOdat

Is anyone working on this?

jtmorrisbytes avatar Aug 17 '21 21:08 jtmorrisbytes

Is anyone working on this?

I don't think so, do you want me to assign it to you?

Razican avatar Aug 18 '21 09:08 Razican

If this is still available, can I work on this?

pdogr avatar Mar 23 '22 10:03 pdogr

If this is still available, can I work on this?

We haven't assigned someone, so please do! Let me assign it to you

jedel1043 avatar Mar 25 '22 21:03 jedel1043

I'll work on this in the next days :)

jedel1043 avatar Sep 22 '22 23:09 jedel1043