node-iconv icon indicating copy to clipboard operation
node-iconv copied to clipboard

Published 20 hours ago • verified publisher icon bnoordhuis

First step on N-API porting

Open NickNaso opened this issue 5 years ago • 4 comments

Hi everyone, I'm opening a new PR about the N-API porting because I want work on this work and I don't have write access to the previous PR (https://github.com/bnoordhuis/node-iconv/pull/189) - I tried to contact the developer that started the the porting work but I never received any answer. If possible please review this PR to move forward on ending this porting.

NickNaso avatar Mar 04 '19 09:03 NickNaso

@bnoordhuis are you going to have a chance to take a look at this updated version?

mhdawson avatar Apr 01 '19 17:04 mhdawson

@bnoordhuis any chance you can review again after @NickNaso rebases.

mhdawson avatar Jun 24 '19 17:06 mhdawson

@NickNaso Sorry for the delay. Can you make sure you rebase against rather than merge in master? Your PR currently has some changes intermixed that already exist in master.

I tried to rebase it myself but there are conflicts in src/binding.cc.

bnoordhuis avatar Jun 25 '19 06:06 bnoordhuis

@bnoordhuis Sorry for delay on working on this. Could you take a look and send your feedback?

NickNaso avatar Oct 29 '19 02:10 NickNaso