node-iconv icon indicating copy to clipboard operation
node-iconv copied to clipboard

Published 20 hours ago • verified publisher icon bnoordhuis

Migration to N-API

Open MrKashlakov opened this issue 5 years ago • 4 comments

Hello! I just did migration of this module to N-API. Please review this PR. All tests passed!

MrKashlakov avatar Nov 08 '18 08:11 MrKashlakov

@bnoordhuis is this something you'd be able to review/consider landing?

mhdawson avatar Jan 28 '19 18:01 mhdawson

Just confirming you are waiting on responses to your comments and once they are addressed it might move forward as we are are talking about whether we need to find somebody else to take over the pr.

@MrKashlakov are you going to be able to get back to this in order to address the comments.

mhdawson avatar Jan 28 '19 18:01 mhdawson

Just confirming you are waiting on responses to your comments and once they are addressed it might move forward

That's correct. This PR also needs a rebase now.

bnoordhuis avatar Jan 28 '19 23:01 bnoordhuis

Hi @MrKashlakov I hope that you have the time to finish this work, but in case if you are busy what do you think if I help you to accomplish at tasks requested in this PR?

NickNaso avatar Feb 04 '19 22:02 NickNaso