node-heapdump icon indicating copy to clipboard operation
node-heapdump copied to clipboard

Enable prebuilt binaries through Github actions

Open qwertzguy opened this issue 3 years ago • 8 comments

Resolves #152

qwertzguy avatar Apr 04 '21 06:04 qwertzguy

Verified that it is able to compile the binaries: https://github.com/qwertzguy/node-heapdump/pull/1/checks?sha=0fa0b311158c85ba142ec335e9bace9a5c7ff415

For it to work, it requires a maintainer to create a github token: https://www.npmjs.com/package/prebuild#create-github-token and then add it in the Settings tab of the repo > Secrets > Name: GITHUB_TOKEN.

It should then run when a new tag starting with the letter "v" is pushed.

qwertzguy avatar Apr 04 '21 07:04 qwertzguy

Let me know if you're ready to merge this. After merging, you would need to follow the steps from my previous comment to setup the github token.

qwertzguy avatar Apr 07 '21 23:04 qwertzguy

Hi @bnoordhuis Is it possible to give me write access to be able to merge this? Or can you merge it?

qwertzguy avatar Apr 22 '21 22:04 qwertzguy

Could you make it prebuild for alpine also? (or is it already?)

williamoliveira avatar Apr 23 '21 00:04 williamoliveira

For it to work, it requires a maintainer to create a github token: https://www.npmjs.com/package/prebuild#create-github-token and then add it in the Settings tab of the repo > Secrets > Name: GITHUB_TOKEN.

Sorry for the delay. I got stuck back then trying to figure out how to scope the personal access token to a single repo. Anyone know if that's possible?

bnoordhuis avatar Oct 10 '21 21:10 bnoordhuis

You can create a "machine user": https://docs.github.com/en/developers/overview/managing-deploy-keys#machine-users

qwertzguy avatar Oct 13 '21 16:10 qwertzguy

I'd really appreciate getting this across the finish line (along with docs showing how to use it). I'm trying to figure out an apparent memory leak that's only reproducing on prod. Anything I can do to help? The machine user solution looks good to me.

kentcdodds avatar Nov 24 '22 19:11 kentcdodds

It requires a maintainer to do the steps I outlined in the 2nd comment.

qwertzguy avatar Nov 29 '22 01:11 qwertzguy