fix for SSLError - new arg `--verify <CA_BUNDLE>`
SSLError #346 final
-
implementation of new arg (--verify <CA_BUNDLE> to allow requests.get setting of verify arg
-
testing updates
- testing exposed one error (ommision) in the implementation which was fixed ;-)
- added import
dotnetused with testing to allow.env.testfile for setting CA_BUNDLE environment variable - added
tests_requirementsto setup.py to support$ python setup.py test - added
requirements-dev.txtto support development (includes black for formatting) - new
settings.pyfile used in testing to read in either environment variable or .env.test variable - tox file revised to now include py3.10 and a development build of py3.11
- /.github/workflow/tests.yml were not updated (they still have
python-version: [3.7, 3.8, 3.9, pypy-3.7])
-
doc updates
- README.rst has new
--verifyoption - CONTRIBUTING.rst note that 3.7 to 3.10 should pass (3.11 needs work)
- README.rst has new
-
final tox runs attached
-
.vscode directory added (it can be ignored if not of interest, my bad)
Cheers
last bit/suggestion
- update
CONTRIBUTING.rstwith note on setting CA_BUNDLE if needed (see below) - and capture the results to a file to submit with pull request
-
When you're done making changes, check that your changes pass flake8 and the tests, including testing other Python versions with tox::
$ flake8 pipreqs tests > flake8_pipreqs_tests_results.txt
-
if needed, set the CA_BUNDLE value in the
.env.testfile located in tests/ (or set an environment variable)$ python setup.py test > python_setup_tests_pipreqs_results.txt
$ tox > tox_pipreqs_results.txt
Thanks also for this PR! What do you think, should we still add this?