pipreqs icon indicating copy to clipboard operation
pipreqs copied to clipboard

File read error was not catched.

Open jarkko-hautakorpi opened this issue 3 years ago • 0 comments

On some file read errors, the file name is not printed. Like: Traceback (most recent call last): File "/home/bob/.local/bin/pipreqs", line 8, in <module> sys.exit(main()) File "/home/bob/.local/lib/python3.7/site-packages/pipreqs/pipreqs.py", line 488, in main init(args) File "/home/bob/.local/lib/python3.7/site-packages/pipreqs/pipreqs.py", line 418, in init follow_links=follow_links) File "/home/bob/.local/lib/python3.7/site-packages/pipreqs/pipreqs.py", line 115, in get_all_imports contents = f.read() File "/usr/lib/python3.7/codecs.py", line 322, in decode (result, consumed) = self._buffer_decode(data, self.errors, final) UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe4 in position 65: invalid continuation byte

Including file read inside the Try gives out better message: ERROR: Failed on file: /home/bob/foofaa/foofaaservice.py Traceback (most recent call last): File "/home/bob/.local/bin/pipreqs", line 8, in <module> sys.exit(main()) File "/home/bob/.local/lib/python3.7/site-packages/pipreqs/pipreqs.py", line 488, in main init(args) File "/home/bob/.local/lib/python3.7/site-packages/pipreqs/pipreqs.py", line 418, in init follow_links=follow_links) File "/home/bob/.local/lib/python3.7/site-packages/pipreqs/pipreqs.py", line 131, in get_all_imports raise exc File "/home/bob/.local/lib/python3.7/site-packages/pipreqs/pipreqs.py", line 116, in get_all_imports contents = f.read() File "/usr/lib/python3.7/codecs.py", line 322, in decode (result, consumed) = self._buffer_decode(data, self.errors, final) UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe4 in position 65: invalid continuation byte

jarkko-hautakorpi avatar Jan 11 '22 14:01 jarkko-hautakorpi